[Webkit-unassigned] [Bug 37299] New: Missing return value in TCMalloc_ThreadCache::GetThreadHeap()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37299

           Summary: Missing return value in
                    TCMalloc_ThreadCache::GetThreadHeap()
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Other
            Status: UNCONFIRMED
          Severity: Trivial
          Priority: P5
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: bnason at netflix.com


It is possible to have a missing return value for the case where HAVE_TLS is
defined, but KernelSupportsTLS() returns false:

inline TCMalloc_ThreadCache* TCMalloc_ThreadCache::GetThreadHeap() {
#ifdef HAVE_TLS
    // __thread is faster, but only when the kernel supports it
  if (KernelSupportsTLS())
    return threadlocal_heap;
#elif COMPILER(MSVC)
    return static_cast<TCMalloc_ThreadCache*>(TlsGetValue(tlsIndex));
#else
    return static_cast<TCMalloc_ThreadCache*>(pthread_getspecific(heap_key));
#endif
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.