[Webkit-unassigned] [Bug 37025] Web Inspector: GC Run event should be added to Timeline Panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37025





--- Comment #23 from jaimeyap at google.com  2010-04-08 16:16:35 PST ---
Sorry. I made a mistake in my diagnosis.

The problem is simpler.

InspectorTimelineAgent::didCompleteRecord() pops the record stack and then
calls addRecordToTimeline()

addRecordToTimeline() pushes the GCEvents. This then attributes the GCEvents to
whatever is currently last on the record stack. Too bad the real parent has
already been popped :).

This means that the only time GCEvents are correctly parented are when they
happen to get pushed by some other peer node closing BEFORE their parent tries
to pop. This is the common case so the data looks mostly correct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.