[Webkit-unassigned] [Bug 37296] New: [Qt] User agent style sheets are crippled by moc -E in make-css-file-arrays.pl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37296

           Summary: [Qt] User agent style sheets are crippled by moc -E in
                    make-css-file-arrays.pl
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Keywords: Qt
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: abecsi at webkit.org


The Qt port uses WebCore/css/make-css-file-arrays.pl with the --preprocessor
moc -E option to remove unneeded comments and whitespaces from default user
agent style sheets found in WebCore/css/, but unforunatelly moc also removes
the @ before at-keywords (for example the namespace keyword) and all
hexadecimal colors beginning with # (moc assumes it is a preprocessor
directive), so the generated arrays in UserAgentStyleSheetsData.cpp include
invalid rules which are ignored by the parser.
Therefore the parser does not set the namespace and does not set colours
specified by the default stylesheets.
Since no other port uses the --preprocessor option, and the script removes
unneeded comments and whitespaces from the css files using regexps anyhow, this
option and the usage of any preprocessor on css files can safely be removed
from the script.
Because of the resulting change in the arrays three platform dependent test
results have to be updated:

editing/execCommand/insert-list-xml.xhtml
svg/custom/createImageElement2.xhtml
svg/custom/use-on-symbol-inside-pattern.svg

These test results are more Mac alike now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.