[Webkit-unassigned] [Bug 37025] Web Inspector: GC Run event should be added to Timeline Panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37025


jaimeyap at google.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jaimeyap at google.com




--- Comment #21 from jaimeyap at google.com  2010-04-08 14:45:23 PST ---
I have a bit of an issue with the way these GCEvents are represented in the
event tree structure.

All nodes in the tree up until now represented a start and end time where the
UI thread was blocked. Unless I am missing something, in situations where the
GCEvent nests in the event tree (where it is not a top level event), the
GCEvent's start and end times can sometimes overlap its peers in the event
tree!

I have confirmed by looking at the data that you can have GCEvents that claim
to happen between X to Y, and when in fact some other peer node claims to
occupy times between X to Y. I would have to assume that in these situations,
the GCEvent simply needs to be a child of this overlapping thing... or else
these GCEvents should not be nodes at all.

This violates a fundamental property of the event tree datastructure. That is,

time in self for a node = my duration - duration of all my children.

If the timings that you are measuring all happen on the UI thread, then in
order to maintain the sanity of the tree structure (non-overlapping peers),
they need to be stuck to the appropriate parent node, or simply recorded as
some kind of aggregate information on a node and not as a node itself.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.