[Webkit-unassigned] [Bug 37287] Rename Wince file to WinCE

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 8 13:53:44 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37287


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-04-08 13:53:44 PST ---
Attachment 52892 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Last 3072 characters of output:
 is incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
JavaScriptCore/wtf/unicode/wince/UnicodeWinCE.h:72:  Code inside a namespace
should not be indented.  [whitespace/indent] [4]
JavaScriptCore/wtf/unicode/wince/UnicodeWinCE.h:211:  One space before end of
line comments  [whitespace/comments] [5]
JavaScriptCore/wtf/unicode/wince/UnicodeWinCE.h:213:  One space before end of
line comments  [whitespace/comments] [5]
JavaScriptCore/wtf/unicode/wince/UnicodeWinCE.cpp:97:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
JavaScriptCore/wtf/unicode/wince/UnicodeWinCE.cpp:121:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
WARNING: Skipping non-existent file:
JavaScriptCore/wtf/unicode/wince/UnicodeWince.h
JavaScriptCore/wtf/wince/FastMallocWinCE.h:22:  #ifndef header guard has wrong
style, please use: FastMallocWinCE_h  [build/header_guard] [5]
JavaScriptCore/wtf/wince/FastMallocWinCE.h:29:  Alphabetical sorting problem. 
[build/include_order] [4]
JavaScriptCore/wtf/wince/FastMallocWinCE.h:34:  n_elements is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
JavaScriptCore/wtf/wince/FastMallocWinCE.h:34:  element_size is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
JavaScriptCore/wtf/wince/FastMallocWinCE.h:41:  n_elements is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
JavaScriptCore/wtf/wince/FastMallocWinCE.h:41:  element_size is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
JavaScriptCore/wtf/wince/FastMallocWinCE.h:83:  Code inside a namespace should
not be indented.  [whitespace/indent] [4]
JavaScriptCore/wtf/wince/FastMallocWinCE.h:86:  One space before end of line
comments  [whitespace/comments] [5]
JavaScriptCore/wtf/wince/FastMallocWinCE.h:87:  One space before end of line
comments  [whitespace/comments] [5]
JavaScriptCore/wtf/wince/FastMallocWinCE.h:88:  One space before end of line
comments  [whitespace/comments] [5]
JavaScriptCore/wtf/wince/FastMallocWinCE.h:89:  One space before end of line
comments  [whitespace/comments] [5]
JavaScriptCore/wtf/wince/FastMallocWinCE.h:90:  One space before end of line
comments  [whitespace/comments] [5]
JavaScriptCore/wtf/wince/FastMallocWinCE.h:91:  One space before end of line
comments  [whitespace/comments] [5]
JavaScriptCore/wtf/wince/FastMallocWinCE.h:92:  One space before end of line
comments  [whitespace/comments] [5]
JavaScriptCore/wtf/wince/FastMallocWinCE.h:93:  One space before end of line
comments  [whitespace/comments] [5]
JavaScriptCore/wtf/wince/FastMallocWinCE.h:156:  One space before end of line
comments  [whitespace/comments] [5]
WARNING: Skipping non-existent file:
JavaScriptCore/wtf/unicode/wince/UnicodeWince.cpp
Total errors found: 25 in 5 files


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list