[Webkit-unassigned] [Bug 36317] [EFL] Add EFL-specific code to Widget.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36317





--- Comment #7 from Gustavo Sverzut Barbieri <barbieri at profusion.mobi>  2010-04-08 12:30:26 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > > What was this one introduced for? Maybe that should be part of the patch that
> > > introduced it?
> > 
> > It is used to move our scrollbars and other widgets like plugins. Our platform
> > is bit different and requires this.
> 
> I think this should go in a port-specific file rather than on the
> cross-platform one. I would mimic what is done in, say, ScrollbarGtk.h. These
> functions are virtual exactly so they can be overriden.

We need this at the widget level, we must be informed about the frameRect
changed so we can act. Unlike other ports, our plugins and other visual
elements (scrollbars) are not moved automatically. We also need to update our
clippers if we use backing store that is bigger than the current viewport.

Also, note that this patch just add an exception for EFL, it does not change
the behavior of old platforms. We just need to be able to implement our own
frameRectChanged() in WidgetEfl.cpp, see
http://trac.webkit.org/browser/trunk/WebCore/platform/efl/WidgetEfl.cpp#L183

If we don't have this, then moving our object into the window will leave stuff
behind :-/  Note that EFL is just managing objects into a scene, it is
windowless, there is no X11 windows being moved that move their children
automatically.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.