[Webkit-unassigned] [Bug 37274] Report resource URL and error details in resource events

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 8 11:57:02 PDT 2010


--- Comment #4 from Darin Adler <darin at apple.com>  2010-04-08 11:57:02 PST ---
(From update of attachment 52868)
> +    m_failingURL = failingURLString; 

Good fix. Where's the test case for this, though? It's separate from the other
fix. We don't take bug fixes without test cases.

> -        // FIXME: it would be nice to have a way to get the real status text eventually.
> -        m_httpStatusText = "OK";
> +        // we used to return "OK" for everything, so be compatible and return "OK" for 200.
> +        m_httpStatusText = m_httpStatusCode == 200 ? String("OK") 
> +                                                   : String([NSHTTPURLResponse localizedStringForStatusCode: m_httpStatusCode]);

Does the localizedStringForStatusCode method exist on all platforms we build
on? Tiger?

Formatting here is wrong -- we normally don't indent the second line of a
conditional expression like this. We just indent by a single tab stop.

What does [NSHTTPURLResponse localizedStringForStatusCode:] return for 200? Do
we really need the hard-coded string?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list