[Webkit-unassigned] [Bug 37228] Allow white listing access from origin to local origin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37228


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52774|review?                     |review-
               Flag|                            |




--- Comment #2 from Adam Barth <abarth at webkit.org>  2010-04-07 13:24:15 PST ---
(From update of attachment 52774)
I like the approach.  Two comments:

 301         if (OriginAccessWhiteList* list =
originAccessMap().get(documentOrigin->toString())) {
 302             PassRefPtr<SecurityOrigin> targetOrigin =
SecurityOrigin::create(url);
 303             for (size_t i = 0; i < list->size();  ++i) {
 304                 if (list->at(i).matchesOrigin(*targetOrigin))
 305                     return true;
 306             }
 307         }

This looks like copy/paste code.  Can we abstract that into a private method?

+var localImageLocation =
layoutTestController.pathToLocalResource('file:///tmp/LayoutTests/http/tests/security/resources/compass.jpg');

Will this file URL work on all platforms (e.g., Windows)?  Is this how other
tests do this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.