[Webkit-unassigned] [Bug 37204] [Chromium] RenderThemeChromiumMac.mm should share code with RenderThemeMac.mm

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 7 06:07:53 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37204





--- Comment #2 from MORITA Hajime <morrita at google.com>  2010-04-07 06:07:53 PST ---
Another idea would be extracting base class for both RenderThemeMac and
RenderThemeChromiumMac.
But it feels overdone for me because RenderThemeChromiumMac is essentially
patched RenderThemeMac.

RenderThemeMac.mm and RenderThemeChromium.mm mac become included 
Chromium mac build, so this change enclose some Mac Webkit specific mehods into 
PLATFORM(MAC) ifdefs. But even with that,
it looks better than extracting something like RenderThemeMacBase, thanks for
smaller the size of change.

It might be massy to have chromium-aware hooks for RenderThemeMac. 
But having copy-n-pasted clone should be worse. 
It would be happy to remove large code duplication in return for small hooks
like this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list