[Webkit-unassigned] [Bug 36949] Web Inspector: remove inspector methods from ScriptExecutionContext and derived classes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36949





--- Comment #24 from Andrey Kosyakov <caseq at chromium.org>  2010-04-07 03:09:01 PST ---
(In reply to comment #21)
> +    virtual void postConsoleMessageToWorkerObject(
> +        int sourceIdentifier,
> +        int messageType,
> +        int messageLevel,
> +        const WebString& message,
> +        int lineNumber,
> +        const WebString& sourceURL)
> 
> This isn't common style in WebKit. We don't wrap lines to make them fit on an
> iPhone screen.

Considering style guide does not state this explicitly, I thought it might be
good idea to preserve existing wrapping style for the file. Fixed per your
request, though.

> 
>      dispatchTaskToMainThread(createCallbackTask(&postConsoleMessageTask, this,
> -                                                static_cast<int>(destination),
>                                                  static_cast<int>(source),
>                                                  static_cast<int>(type),
>                                                  static_cast<int>(level),
> 
> I'm not sure if these type casts are necessary.

They're not indeed (fixed this as well). As you can see, it wasn't me who added
them, just tried to minimize patch footprint.

> -__ZN20WebFrameLoaderClient39dispatchDidLoadResourceByXMLHttpRequestEmRKN7WebCore12ScriptStringE
> 
> There is no need to touch WebCore.order - Apple updates it as necessary, and
> it's not used by other vendors.

Thanks, fixed. 

>+        Removed redundant
> FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache()
> I don't think that's true.

Indeed, I accidently put a wrong method name there. Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.