[Webkit-unassigned] [Bug 36899] Make DumpRenderTree parallelizable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36899





--- Comment #8 from Csaba Osztrogonac <ossy at webkit.org>  2010-04-07 02:50:27 PST ---
(In reply to comment #7)
> (From update of attachment 52261 [details])
> I don't believe that this is sufficient to make Mac work, but it is probably
> better than what we have now.
This patch isn't enough to make Mac work, but it is 
necessary to avoid concurent database file accessses.

We have ideas to fix other problems mentioned here and 
in the master bug. But I don't want to upload a very big 
patch for review. I prefer one patch for one separated fix.

> Also, why call getenv so many times?  Why not just once and cache the result in
> a local variable?
You're right, it isn't so nice, I'll fix. New patch is coming soon.

> Do we know if this makes the IconDatbase crashers on the Qt bot go away?
I'm not sure enough, but I hope yes. I didn't want to apply this patch
for testing on the official bot before landing, because I'm afraid of svn
conflict and following fresh build. :))

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.