[Webkit-unassigned] [Bug 37194] Prevent wrong use of PrintContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37194


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52714|review?                     |
               Flag|                            |




--- Comment #2 from Shinichiro Hamaji <hamaji at chromium.org>  2010-04-07 01:59:45 PST ---
(From update of attachment 52714)
>  PrintContext::~PrintContext()
>  {
> +    if (m_isPrinting)
> +        end();
>      m_pageRects.clear();
>  }

Or, we may want to add ASSERT(!m_isPrinting) here. I personally like this kind
of automatic release, but I'm not sure if this is suitable for this case. If a
user of PrintContext relies on this, her/his code may have begin() without
end(), which might look weird a bit. Hmm... I changed my mind while I'm writing
this comment. I'll revise the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.