[Webkit-unassigned] [Bug 37182] New: WebCore config.h hardcodes the wince OS policies.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37182

           Summary: WebCore config.h hardcodes the wince OS policies.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Other
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jasonr at bsquare.com


I'm looking to start submitting changes to support the Windows CE platform; I
picked this as a first change so that I can see the patch review process
through; hopefully without affecting anything.

The following definition in config.h forces OS(WINCE) into a set of policies on
building that cannot be overriden easily to be different to the windows build.

#if PLATFORM(WIN)
#if defined(WIN_CAIRO)
#undef WTF_PLATFORM_CG
#define WTF_PLATFORM_CAIRO 1
#undef WTF_USE_CFNETWORK
#define WTF_USE_CURL 1
#ifndef _WINSOCKAPI_
#define _WINSOCKAPI_ // Prevent inclusion of winsock.h in windows.h
#endif
#else
#define WTF_PLATFORM_CG 1
#undef WTF_PLATFORM_CAIRO
#define WTF_USE_CFNETWORK 1
#undef WTF_USE_CURL
#endif
#undef WTF_USE_WININET
#define WTF_PLATFORM_CF 1
#define WTF_USE_PTHREADS 0
#endif

I would like to change this to 

#if PLATFORM(WIN) && !OS(WINCE)

so that WINCE can set the policies in wtf/platform.h (or have them overriden
from the default); especially items like using WININET and WTF_PLATFORM_CF
which are not available on windows CE.  I am using a build that is windows CE
for CAIRO+WININET+PTHREADS and these hardcoded values for the policies for
PLATFORM(WIN) don't allow options for the build configuration.

I have a patch for this change available.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.