[Webkit-unassigned] [Bug 37164] Poor rendering on lala.com with frame flattening

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 6 14:59:52 PDT 2010


--- Comment #24 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-04-06 14:59:51 PST ---
(From update of attachment 52671)

> +    if (!node()->document()->topDocument()->frame()->view()->visibleContentRect().intersects(node()->renderer()->absoluteClippedOverflowRect()))
> +        return false;
> +
>      return frame->document()->frame() && frame->document()->frame()->settings()->frameFlatteningEnabled();

I guess that doing the intersection is more costly than checking the setting,
so the common case of not having frame flattening so not be made slower. I
suggest swapping the tests.

Also, are you sure that all of these will always remain non-null?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list