[Webkit-unassigned] [Bug 37164] Poor rendering on lala.com with frame flattening

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37164


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52657|review?                     |review+
               Flag|                            |




--- Comment #8 from Darin Adler <darin at apple.com>  2010-04-06 13:53:30 PST ---
(From update of attachment 52657)
> +    if (isPositioned() && containingBlock() == view() && ((x() + width() <= 0) || (y() + height() <= 0)))
> +        return false;

"x() + width()" is "frameRect().right()" and I think we should use that
instead.

"y() + height()" is "frameRect().bottom()" and I think we should use that
instead

A much better way to do this would be to call frameRect().intersects(xxx),
where xxx is the viewport. Checking specifically for right and bottom that are
off the left and top edge is too specific and will miss other valuable cases.

r=me despite these concerns

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.