[Webkit-unassigned] [Bug 37154] V8CustomIDBCallbacks<> should not hold a reference to the frame

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 6 12:26:48 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37154





--- Comment #6 from Jeremy Orlow <jorlow at chromium.org>  2010-04-06 12:26:47 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > +     v8::Persistent<v8::Object> m_onSuccess;
> > +     v8::Persistent<v8::Object> m_onError;
> > 
> > Please use OwnHandle instead to avoid manual new/dispose.
> 
> Oooo.  Nice.

Unfortunately, I think this will need to wait because changing it would require
me to change VoidCallback.  And I want to do that once we have our story fully
sorted out for IndexedDB.

I'll add a FIXME for now though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list