[Webkit-unassigned] [Bug 36949] Web Inspector: remove inspector methods from ScriptExecutionContext and derived classes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 6 10:56:50 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36949





--- Comment #21 from Alexey Proskuryakov <ap at webkit.org>  2010-04-06 10:56:48 PST ---
+    virtual void postConsoleMessageToWorkerObject(
+        int sourceIdentifier,
+        int messageType,
+        int messageLevel,
+        const WebString& message,
+        int lineNumber,
+        const WebString& sourceURL)

This isn't common style in WebKit. We don't wrap lines to make them fit on an
iPhone screen.

     dispatchTaskToMainThread(createCallbackTask(&postConsoleMessageTask, this,
-                                                static_cast<int>(destination),
                                                 static_cast<int>(source),
                                                 static_cast<int>(type),
                                                 static_cast<int>(level),

I'm not sure if these type casts are necessary.

-__ZN20WebFrameLoaderClient39dispatchDidLoadResourceByXMLHttpRequestEmRKN7WebCore12ScriptStringE

There is no need to touch WebCore.order - Apple updates it as necessary, and
it's not used by other vendors.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list