[Webkit-unassigned] [Bug 37025] Web Inspector: GC Run event should be added to Timeline Panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37025


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52621|review?                     |review-
               Flag|                            |




--- Comment #16 from Pavel Feldman <pfeldman at chromium.org>  2010-04-06 05:39:46 PST ---
(From update of attachment 52621)
r- for iterating over original and for poor 'helper' name.

ScriptGCEventHelper is no longer a good name since you can't add listeners to
the helper.

> +public:
> +    static void addEventListener(ScriptGCEventListener*){}
> +    static void removeEventListener(ScriptGCEventListener*){}
> +    static void getHeapSize(size_t&, size_t&){}

should be ") { }"

> +    double endTime = WTF::currentTimeMS();
> +    size_t collectedBytes = s_usedHeapSize - getUsedHeapSize();
> +    for (GCEventListeners::iterator i = s_eventListeners.begin(); i != s_eventListeners.end(); ++i)
> +        (*i)->didGCRun(s_startTime, endTime, collectedBytes);

You should iterate over copy in case client wants to unregister listener after
the first event or something similar.

> +    typedef Vector< ScriptGCEventListener* > GCEventListeners;

Vector<ScriptGCEventListener*>

> +    virtual void didGCRun(double startTime, double endTime, size_t collectedBytes) = 0;

didGC?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.