[Webkit-unassigned] [Bug 36500] Generated JIT stubs does not compile because of compiler directives

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36500





--- Comment #2 from Gabor Loki <loki at webkit.org>  2010-04-06 01:35:21 PST ---
Although I did not like this patch at first sight, now I am starting to think
this solution is fine.

I was playing with RVCT last weeks, and saw this problem as well. My quick fix
was to emit each stub functions once by create_jit_stubs script, and add extra
stub function bodies for all cases of #if directives in JITStubs.cpp. Laszlo's
fix was similar (r56842) without the script modification.

David's patch considers those macros which can enable/disable a JIT feature in
JITStubs.cpp. So it is useful if someone wants to change the default behavior.
In additional this patch will not increase the binary with dead codes.

Btw, I have some suggestions about the patch. The $if, $endif and $hash should
consider whitespaces as well. For example: my $if="[\t ]*#[\t ]*if" , or
something similar. It would be nice if $hash is renamed to $else which contains
"[\t ]*#[\t ]*el(se|if)" regexp. Finally, David, you should revert Laszlo's
quick fix in your patch as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.