[Webkit-unassigned] [Bug 37026] [Qt] WebKit does not build on Windows with --3d-canvas

Mon Apr 5 23:41:41 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=37026

Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52576|review?                     |review+
               Flag|                            |

--- Comment #7 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2010-04-05 23:41:41 PST ---
(From update of attachment 52576)
>  // FIXME: Find a better way to avoid the name confliction for NO_ERROR.
> -#if ((PLATFORM(CHROMIUM) && OS(WINDOWS)) || PLATFORM(WIN))
> +#if ((PLATFORM(CHROMIUM) && OS(WINDOWS)) || PLATFORM(WIN) || (PLATFORM(QT) && OS(WINDOWS)))
>  #undef NO_ERROR
>  #endif

It seems to me that this test should be simply OS(WINDOWS), instead of listing
all the ports one-by-one that builds on Windows.

This looks good to me as a build fix, r+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.