[Webkit-unassigned] [Bug 37059] SheriffBot should force_build builders that are idle and have failed exactly once

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 5 19:43:11 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37059


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52488|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #4 from Eric Seidel <eric at webkit.org>  2010-04-05 19:43:11 PST ---
(From update of attachment 52488)
Why the crazy caching?
 109     def provoke_flaky_builders(self, revisions_causing_failures=None):
 110         if revisions_causing_failures == None:
 111             revisions_causing_failures =
self._tool.buildbot.revisions_causing_failures()

I give you {}.values()
116         failed_builder_names = \
 117             set([revisions_causing_failures[key].name()
 118                  for key in revisions_causing_failures.keys()])

the red_idle_builders code should be its own function.

Otherwise looks OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list