[Webkit-unassigned] [Bug 37025] Web Inspector: GC Run event should be added to Timeline Panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37025


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52555|review?                     |review-
               Flag|                            |




--- Comment #13 from Pavel Feldman <pfeldman at chromium.org>  2010-04-05 12:18:52 PST ---
(From update of attachment 52555)
Looks better, but bi-directional dependency is still there. Could you introduce
a ScriptGCHelperListener (as ScriptDebugServerListener in WebCore/inspector) to
resolve that?

Rest of the nits below. 


> +namespace WebCore {
> +class ScriptGCEventHelper
> +{

Ad blank line here.

> +public:
> +    ScriptGCEventHelper(InspectorTimelineAgent*){}
> +    static void getHeapSize(size_t&, size_t&) {}
> +};

Ad blank line here.

> +} // namespace WebCore

> +namespace WebCore {

Ad blank line here.

> +    static int s_helpersCounter;

I guess this one is no longer needed.

> -    : m_frontend(frontend)
> +    : m_frontend(frontend), m_gcEventHelper(this)

Move ", m_gcEventHelper" to the next line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.