[Webkit-unassigned] [Bug 37008] ScriptController::processingUserGestureEvent returns true for simulated clicks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 2 20:43:51 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37008


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52474|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #20 from Adam Barth <abarth at webkit.org>  2010-04-02 20:43:49 PST ---
(From update of attachment 52474)
+ namespace WebCore {

We usually have a blank line under the namespace declaration.

+ static inline bool processingUserGesture() { return s_processingUserGesture;
}

No need to declare inline here.

+ #include <new>

Why do we need this here?

Also, please fix the Chromium build failure.  If you were a committer, I would
r+ your patch and ask you to fix these things on landing, but as a
non-committer, I'm going to ask you to upload a new patch so we can land it
using the bot.

Thanks for the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list