[Webkit-unassigned] [Bug 36904] Clean up chromium WebNotificationPresenter interface after notification changes

Fri Apr 2 11:37:49 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=36904

David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52428|review?                     |review+
               Flag|                            |

--- Comment #9 from David Levin <levin at chromium.org>  2010-04-02 11:37:49 PST ---
(From update of attachment 52428)

> diff --git a/WebKit/chromium/public/WebNotificationPresenter.h b/WebKit/chromium/public/WebNotificationPresenter.h

> +    virtual Permission checkPermission(const WebURL& url) = 0;
The parameter name "url" adds no information so it shouldn't be present.

> +    virtual void requestPermission(const WebSecurityOrigin& origin, WebNotificationPermissionCallback* callback) = 0;

"origin" and "callback" param names should be removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.