[Webkit-unassigned] [Bug 36949] Web Inspector: remove inspector methods from ScriptExecutionContext and derived classes
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 2 09:00:51 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=36949
--- Comment #12 from Andrey Kosyakov <caseq at chromium.org> 2010-04-02 09:00:50 PST ---
(In reply to comment #10)
> (From update of attachment 52411 [details])
> This patch looks great. I'm really happy we're going to stop spamming the
> console with XHR finished messages.
>
> I'm surprised this didn't change the expected results of any LayoutTests. I'd
> imagine that any test that used XHR would have its expected output changed.
> Are you sure you ran all the tests?
>
> Please separate this change into two patches:
> 1) Removing the console spam.
> 2) Removing all the dead code.
>
> Thanks for the patch.
Thanks -- I'll split the patch. The tests are fine, 'cause we removed
messages that were only sent to inspector console (not the Console) -- there
don't seem to be tests that cover this.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list