[Webkit-unassigned] [Bug 36949] Web Inspector: remove inspector methods from ScriptExecutionContext and derived classes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 2 08:40:21 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36949


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52411|review?                     |review-
               Flag|                            |




--- Comment #10 from Adam Barth <abarth at webkit.org>  2010-04-02 08:40:20 PST ---
(From update of attachment 52411)
This patch looks great.  I'm really happy we're going to stop spamming the
console with XHR finished messages.

I'm surprised this didn't change the expected results of any LayoutTests.  I'd
imagine that any test that used XHR would have its expected output changed. 
Are you sure you ran all the tests?

Please separate this change into two patches:
1) Removing the console spam.
2) Removing all the dead code.

Thanks for the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list