[Webkit-unassigned] [Bug 36949] Web Inspector: remove inspector methods from ScriptExecutionContext and derived classes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36949





--- Comment #6 from Andrey Kosyakov <caseq at chromium.org>  2010-04-02 08:17:58 PST ---
(In reply to comment #5)
> (From update of attachment 52411 [details])
> >  
> > -        scriptExecutionContext()->scriptImported(scriptLoader.identifier(), scriptLoader.script());
> >  #if ENABLE(INSPECTOR)
> > -        scriptExecutionContext()->addMessage(InspectorControllerDestination, JSMessageSource, LogMessageType, LogMessageLevel, "Worker script imported: \"" + *it + "\".", callerLine, callerURL);
> > +        if (InspectorController* inspector = scriptExecutionContext()->inspectorController())
> > +            inspector->scriptImported(scriptLoader.identifier(), scriptLoader.script());
> >  #endif
> Looks like after this change script imports won't be reported to the user
> because InspectorController will be 0.

addMessage() was dropped intentionally (we don't want this reported to
console), and scriptImported() didn't work before (used to be notImplemented()
before the patch) -- this will only be fixed once we implement worker
debugging.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.