[Webkit-unassigned] [Bug 36995] Improve the error handling in rollout a bit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 1 20:36:47 PDT 2010


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #52365|review?                     |review+
               Flag|                            |

--- Comment #4 from Eric Seidel <eric at webkit.org>  2010-04-01 20:36:47 PST ---
(From update of attachment 52365)
Explain why in your comment, please:
            # Note: Don't print a bug URL here because it will confuse the
 259             #       SheriffBot.  Yes, that's lame.
 260             log("Preparing rollout for bug %s." % commit_info.bug_id())

 267         cc = sorted([party.bugzilla_email()

We should be passing around lists instead of a string:
 273             "bug_cc": ",".join(cc),

Anyway, this looks fine.  We should fix the cc passing around at some point. 
Ideally now, but not required.  Either way I don't need to see this again.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list