[Webkit-unassigned] [Bug 36394] Include git commits in the diff for webkit-patch upload/land.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 1 18:16:03 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36394


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52305|review?                     |review-
               Flag|                            |




--- Comment #40 from Eric Seidel <eric at webkit.org>  2010-04-01 18:16:03 PST ---
(From update of attachment 52305)
Ojan and I reviewed this in person.

r=me on the prepare-ChagneLog changes.
He's going to post a new patch with just the svn_branch_name, svn_merge_base,
delete_branch stuff and tests.
And I believe his plan is to re-write this to pass the individual options as
arguments to the various functions which need them.  Mostly some different
plumbing, but should be easier to understand than a stateful Git class.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list