[Webkit-unassigned] [Bug 31680] WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31680


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52279|review?                     |review+
               Flag|                            |




--- Comment #25 from Darin Adler <darin at apple.com>  2010-04-01 16:36:31 PST ---
(From update of attachment 52279)
> -    if (!n || selection->isNone())
> +    if (!n || m_frame->document() != n->document() || selection->isNone())
>          return false;

Why did you choose not to use your isValidForPosition helper function here?

> +bool DOMSelection::isValidForPosition(Node* node) const
> +{
> +    ASSERT(m_frame);
> +    if (!node)
> +        return true;
> +    return (node->document() == m_frame->document());
> +}

Extra parentheses here.

r=me

Lets send the feedback to the HTML5 folks about not the need to not raise
exceptions in these cases for compatibility.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.