[Webkit-unassigned] [Bug 36983] New: new-run-webkit-tests ignores trailing EOL differences in text tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36983

           Summary: new-run-webkit-tests ignores trailing EOL differences
                    in text tests
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jamesr at chromium.org


The python new-run-webkit-tests differ ignores trailing EOLs for text tests. 
The offending code is webkitpy/layout_tests/test_types/text_diff.py line 81
(http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/layout_tests/test_types/text_diff.py#L81):

        # Normalize line endings
        return text.strip("\r\n").replace("\r\n", "\n") + "\n"

Unfortunately in python str.strip() takes a set of chars, not a sequence, so
this line strips all trailing '\r' and '\n' characters.

This is inconsistent with the perl script
(https://bugs.webkit.org/attachment.cgi?id=52198&action=prettypatch passes with
new-run-webkit-tests and fails with run-webkit-tests).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.