[Webkit-unassigned] [Bug 36901] RVCT generates incorrect code for method Range::operator== when compiler optimizations are enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36901





--- Comment #3 from Daniel Bates <dbates at webkit.org>  2010-04-01 10:16:20 PST ---
(In reply to comment #2)
> (From update of attachment 52214 [details])
> It's illegal to dereference a null pointer and make a reference from it. So
> code that checks:
> 
>     if (!&a || !&b)
> 
> is not legal C++. The right way to fix this is to restructure our code so we
> don't rely on this sort of illegal C++. It's OK with me to do this
> compiler-specific optimization hacking as an interim measure, but it seems like
> a bad strategy. Much better would be to eliminate this.

I agree we should eliminate this.

> One simple way to do this would be to eliminate the Range operator== entirely
> and add a named function (isEqual or areEqual or something along those lines)
> that takes range pointers.

Will add.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.