[Webkit-unassigned] [Bug 36394] Include git commits in the diff for webkit-patch upload/land.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 1 08:06:06 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36394





--- Comment #33 from Ojan Vafai <ojan at chromium.org>  2010-04-01 08:06:05 PST ---
(In reply to comment #32)
> Technically, you shouldn't be passing options to scm.py.  Options are part of
> the command/step API, but scm.py is one layer further down.

Yeah, I thought about that as I was writing it. I actually started out giving
create_patch, changed_files and commit_with_message optional git_commit and
squash arguments. That quickly got very messy though. There's a lot of code
that calls those that doesn't have access to options.

Anyways, how about I SCM takes squash and git_commit arguments instead of
options?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list