[Webkit-unassigned] [Bug 36890] Web Inspector: Timeline Events are not propagated to frontend.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36890


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52291|review?                     |review+
               Flag|                            |




--- Comment #3 from Yury Semikhatsky <yurys at chromium.org>  2010-04-01 07:21:40 PST ---
(From update of attachment 52291)
>              if (timelineAgent) {
>                  v8::ScriptOrigin origin = function->GetScriptOrigin();
>                  if (!origin.ResourceName().IsEmpty())
> -                    timelineAgent->willCallFunction(v8ValueToWebCoreString(origin.ResourceName()), function->GetScriptLineNumber() + 1);
> +                    timelineAgent->willCallFunction(toWebCoreString(origin.ResourceName()), function->GetScriptLineNumber() + 1);
It may be useful to see function calls even if resource name is empty.

> +        if (inspectedPage) {
> +            InspectorTimelineAgent* timelineAgent = inspectedPage->inspectorTimelineAgent();
> +            if (timelineAgent)
> +                timelineAgent->didCallFunction();
> +        }
If you move timelineAgent declaration out of the if before the function call
above if (inspectedPage) can be removed.

> +    if (inspectedPage) {
> +        InspectorTimelineAgent* timelineAgent = inspectedPage->inspectorTimelineAgent();
> +        if (timelineAgent)
> +            timelineAgent->didDispatchEvent();
> +    }
Ditto.


> +    if (inspectedPage) {
> +        InspectorTimelineAgent* timelineAgent = inspectedPage->inspectorTimelineAgent();
> +        if (timelineAgent)
>              timelineAgent->didDispatchEvent();
>      }
Just checking if (timelineAgentIsActive) here would make the code more clear.


Could we have a test for the case when frame is detached?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.