[Webkit-unassigned] [Bug 36802] setting document.title doesn't change document.title value

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 1 04:09:42 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36802





--- Comment #11 from MORITA Hajime <morrita at google.com>  2010-04-01 04:09:41 PST ---
Darin, thank you reviewing!
I updated the patch.

(In reply to comment #7)
> Typo: "Document:seTitle".
> (snip)
> Typo here: "documen"
Fixed.

> 
> > +        // We make a copy here because value.m_impl will be changed implicitly during removeChildren(),
> > +        // which causes HTMLTitleElement::childrenChanged(), which ends up Document::setTitle().
> > +        String valueCopy(value);
> 
> The comment is a little confusing because strings are immutable. The real issue
> is that value is a reference to a string from the DOM tree.
Agreed. And tried to clarify the comment.

> 
> But given the special case this patch added above for empty values and no
> children, I don't think this second code change actually matters. Could you
> test without this second change? I believe only the isEmpty change is needed.
This was required. But the fix on Bug 25567 made this special case no longer
usefull.
Thank you pointing it out at #8.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list