[Webkit-unassigned] [Bug 31680] WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 1 03:12:31 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=31680





--- Comment #23 from MORITA Hajime <morrita at google.com>  2010-04-01 03:12:30 PST ---
Darin, thank you for reviewing.
And I'm sorry for my short of attention to the standard compatibility.
I updated the patch.

> Does the HTML5
> specification or another W3C specification mention this? What does it say?
HTML5 says that we should throw exceptions for nodes from foreign documents, as
you mentioned.
http://www.whatwg.org/specs/web-apps/current-work/#selection

> Does any other browser implement this? What does that browser do? Is there any
> documentation for this? What does the documentation say? 
Firefox accepts foreign nodes. But its behavior is different from us.
In Firefox, selection of certain window (or document) can hold nodes from
another document.
But rendering doesn't reflect it.
For example, when selection.collapse(foreignNode, 0), selection.anchorNode is
set to foreignNode.
with nothing selected(highlighted) on the foreign document (nor the document of
the selection).
This behavior is incompatible to HTML5 standard,
It is also hard to follow for WebKit due to our VisiblePosition design
that requires the valid nodes of selection's own document.

IE doesn't support selection API.

Updated patch goes between Firefox and HTML5 spec.
The patch just ignores foreign node, without throwing an exception.
Doing so, applications will keep running somehow even if they assume Firefox
model, 
in contrast to throwing exception that will stop the program.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list