[Webkit-unassigned] [Bug 36944] Chromium InspectorFrontendHost does not correctly implement canAttachWindow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36944


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52277|review?                     |review-
               Flag|                            |




--- Comment #4 from Pavel Feldman <pfeldman at chromium.org>  2010-04-01 02:25:27 PST ---
(From update of attachment 52277)
Overall looks good. Could of nits that need to be fixed prior to landing.

> diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
> index 551c957..aefd631 100644
> --- a/WebKit/chromium/ChangeLog
> +++ b/WebKit/chromium/ChangeLog
> @@ -1,3 +1,16 @@
> +2010-04-01  Mattias Nissler  <mnissler at chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Implement canAttachWindow() for the WebDevToolsFrontendImpl implementation of
> +        InspectorFrontendHost and forward the call to WebDevToolsFrontendClient. This
> +        allows us to implement canAttachWindow() properly in the chromium code.
> +

ChangeLog entry should reference bug url here.

> +    WebDevToolsFrontendImpl* frontend = static_cast<WebDevToolsFrontendImpl*>(v8::External::Cast(*args.Data())->Value());
> +    frontend->m_client->sendDebuggerPauseScript();

No need to pause debugger for this one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.