[Webkit-unassigned] [Bug 29825] [V8] Refactored V8 event listeners.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29825


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40360|review?                     |review-
               Flag|                            |




--- Comment #8 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2009-09-30 10:26:50 PDT ---
(From update of attachment 40360)
This is super-awesome. I only have style nits.

I would really like to use enums for isAttribute params in getEventListener.
That should clarify the call sites.

> +    V8Proxy* proxy = V8Proxy::retrieve(worker->scriptExecutionContext());
> +    if (proxy) {
> +        return findOnly ? V8EventListenerList::findWrapper(value, isAttribute) : V8EventListenerList::findOrCreateWrapper<V8EventListener>(proxy->frame(), value, isAttribute);
> +    }

Don't need braces here.

> +    if (proxy) {
> +        return findOnly ? V8EventListenerList::findWrapper(value, isAttribute) : V8EventListenerList::findOrCreateWrapper<V8EventListener>(proxy->frame(), value, isAttribute);
> +    }

Ditto.

> +v8::Handle<v8::String> V8HiddenPropertyName::listener()
> +{
> +    static v8::Persistent<v8::String>* string = createString("WebCore::V8HiddenPropertyName::listener");
> +

no line break here.

> +    return *string;
> +}
> +
> +v8::Handle<v8::String> V8HiddenPropertyName::attributeListener()
> +{
> +    static v8::Persistent<v8::String>* string = createString("WebCore::V8HiddenPropertyName::attributeListener");

Ditto.

> +void V8Proxy::disconnectEventListeners()
> +{
> +}
> +

Why is this here? Can we just get rid of it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.