[Webkit-unassigned] [Bug 29656] Make WebKitTools/Scripits/run-sunspider script work on Windows platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29656





--- Comment #13 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2009-09-30 08:26:20 PDT ---
(In reply to comment #12)
> (From update of attachment 40365 [details])
> > diff --git a/WebKitTools/Scripts/webkitdirs.pm b/WebKitTools/Scripts/webkitdirs.pm
> >  # used for scripts which are stored in a non-standard location
> > +sub currentPerlPath()
> > +{
> > +    return $^X;
> > +}
> 
> I really think you should use the method from Comment #8 due to the reasons I
> outlined in Comment #11:  it's guaranteed to work, and we don't know exactly
> which platforms it's needed on.

If you change the method back, I will r+ the patch.  Everything else looks
good!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.