[Webkit-unassigned] [Bug 29656] Make WebKitTools/Scripits/run-sunspider script work on Windows platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29656





--- Comment #11 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2009-09-30 08:22:31 PDT ---
(In reply to comment #9)
> > sub currentPerlPath()
> > {
> >     my $thisPerl = $^X;
> >     if ($^O ne 'VMS') {
> >         $thisPerl .= $Config{_exe} unless $thisPerl =~ m/$Config{_exe}$/i;
> >     }
> >     return $thisPerl;
> > }
> 
> I don't see why we should use this method to determine the actual Perl
> interpreter. Why don't use simple $^X? I think all windows platform don't need
> .exe suffixes. And my ActiveState Perl 5.10.0 said that its interpreter is
> c:\perl\bin\perl.exe. It works with ...perl and ...perl.exe too.
> 
> Do you know a perl used by WebKit developers which needs this very complex
> method? I think we can use simple "return $^X".

The problem is that the manpage doesn't say which platforms need the workaround
(and I have no more knowledge that the manpage on this one).  You say you don't
need it with ActiveState Perl, but have you tested all combinations of
ActiveState Perl, Cygwin's Perl, "native" (DOS/Windows-only) Perl and invoking
the script from both a DOS shell and a Cygwin shell?

I think it's best to follow the manpage on this one.  It certainly won't hurt
to use the code, and it's guaranteed to work.  (It would probably make sense to
add a comment to the subroutine that mentions the perlvar manpage, though.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.