[Webkit-unassigned] [Bug 29867] [Qt] QWebPage autotest has three failures

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29867


jedrzej.nowacki at nokia.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40363|                            |review?, commit-queue-
               Flag|                            |




--- Comment #2 from jedrzej.nowacki at nokia.com  2009-09-30 05:35:50 PDT ---
Created an attachment (id=40363)
 --> (https://bugs.webkit.org/attachment.cgi?id=40363)
idea of patch

Ok, results of "looking"...

testEnablePersistentStorage works after fix for 29844 bug.

test testOptionalJSObjects is broken because of DOMWindow.cpp. I attached
patch. 
The patch SHOULD _NOT_ be committed, only reviewed. I think it is good, but it
was reverted in bug 28359
(https://bugs.webkit.org/show_bug.cgi?id=28359) because:
"made a change to return 'null' for window.applicationCache when the feature is
disabled in the preferences."

According to w3 documentation
(http://www.whatwg.org/specs/web-apps/current-work/#application-cache-api)
window.applicationCache should return an object to AplicationCache. So I think
it is pretty normal to return null if cache is disabled (there is no object).

so, why this patch is bad?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.