[Webkit-unassigned] [Bug 29842] [GTK] data: uri support in media player

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29842


Sebastian Dröge <slomo at circular-chaos.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org




--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org>  2009-09-30 04:12:23 PDT ---
Some notes on the GStreamer part:

- use gst_ghost_pad_new_no_target_from_template() instead of
gst_ghost_pad_new_no_target() (gives pad<->template association)
- use gst_element_set_details_simple() instead of the one with _simple()
(results in smaller compiled code)
- do something useful if there's no giostreamsrc available (like posting a
missing plugin message on the bus in GstElement::change_state when going from
READY->PAUSED and returning FAILURE there)
- in set_uri: a) pass g_free as GDestroyNotify for the memory input stream and
b) unref it after setting it in the giostreamsrc
- Small leak in failure case in set_uri, you don't free the string array

And then you might want to add the child in NULL->READY and remove it again in
READY->NULL but that not exactly necessary :) Also, changing the URI in states
>= PAUSED shouldn't be allowed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.