[Webkit-unassigned] [Bug 29544] Make sunspider script work on Windows platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29544


Zoltan Horvath <zoltan at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40224|commit-queue?               |commit-queue+
               Flag|                            |




--- Comment #11 from Zoltan Horvath <zoltan at webkit.org>  2009-09-30 00:55:56 PDT ---
(From update of attachment 40224)
> diff --git a/SunSpider/ChangeLog b/SunSpider/ChangeLog
> index e121eeb..8aa63bf 100644
> --- a/SunSpider/ChangeLog
> +++ b/SunSpider/ChangeLog
> @@ -1,3 +1,12 @@
> +2009-09-28  Csaba Osztrogonac  <oszi at inf.u-szeged.hu>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Platform specific null device replaced with a platform independent.
> +        https://bugs.webkit.org/show_bug.cgi?id=29544
> +
> +        * sunspider: Using File::Spec->devnull() instead of /dev/null and NUL.
> +
>  2009-09-21  Csaba Osztrogonac  <oszi at inf.u-szeged.hu>
>  
>          Reviewed by Maciej Stachowiak.
> diff --git a/SunSpider/sunspider b/SunSpider/sunspider
> index 7825a63..20614b1 100755
> --- a/SunSpider/sunspider
> +++ b/SunSpider/sunspider
> @@ -160,8 +160,7 @@ sub writePrefixFile()
>  sub runTestsOnce($)
>  {
>      my ($useShark) = @_;
> -    my $nullDevice = ($^O eq "MSWin32") ? "NUL" : "/dev/null";
> -    my $shellArgs = $jsShellArgs . " -f $prefixFile -f resources/sunspider-standalone-driver.js 2> " . $nullDevice;
> +    my $shellArgs = $jsShellArgs . " -f $prefixFile -f resources/sunspider-standalone-driver.js 2> " . File::Spec->devnull();
>      my $output;
>      if ($useShark) {
>          my $intervalArg = $useShark == 20 ? "-I 20u" : "";

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.