[Webkit-unassigned] [Bug 29907] [Chromium] Incorrect conditions in WebCore.gyp

Tue Sep 29 18:27:52 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=29907

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40336|0                           |1
           is patch|                            |

--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-09-29 18:27:52 PDT ---
(From update of attachment 40336)
Forgot to click the "patch" checkbox.  Tools like "bugzilla-tool post-diff"
will do all that for you.

Also your ChangeLog should really have the bug number in it.  prepare-ChangeLog
--bug will do that.

This is covered in http://webkit.org/coding/contributing.html

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.