[Webkit-unassigned] [Bug 29826] Add support for run-time flag for 3D canvas

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29826


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40259|review?(dglazkov at chromium.o |review-
               Flag|rg)                         |




--- Comment #3 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2009-09-28 21:34:02 PDT ---
(From update of attachment 40259)
Mostly procedural nits.

> +2009-09-28  Kenneth Russell  <kbr at google.com>
> +
> +        Reviewed by dglazkov at chromium.org(?), cmarrin at apple.com(?).

You probably shouldn't remove the OOPS from here until reviewed. The pre-commit
hook makes it your last line of defense.
However -- you don't have a commit bit, so my point is Moooo-t :)

> +
> +        Add support for run-time flag for 3D canvas
> +        https://bugs.webkit.org/show_bug.cgi?id=29826
> +
> +        * DerivedSources.make: Conditionally add
> +	Settings::setExperimentalWebGLEnabled to exported symbol list.
Weird indentation here. Tabs maybe?

> +        * WebCore.WebGL.exp: Added.
> +        * html/HTMLCanvasElement.cpp:
> +        (WebCore::HTMLCanvasElement::getContext): Check page settings for
> +	experimental WebGL flag before returning 3D graphics context.

Ditto.

> +
> +        * WebView/WebView.mm:
> +        (-[WebView _preferencesChangedNotification:]): Enable experimental
> +	WebGL flag when 3D_CANVAS is enabled in the build.

Ditto.

>  
> +#if ENABLE(3D_CANVAS)
> +    settings->setExperimentalWebGLEnabled(true);
> +#endif  // ENABLE(3D_CANVAS)

I didn't realize Win was a supported platform. If it's not, should we do this
for all other ports, then?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.