[Webkit-unassigned] [Bug 29802] [Qt] Make build-webkit script work on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29802


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40225|review?                     |review-
               Flag|                            |




--- Comment #2 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2009-09-28 16:49:25 PDT ---
(From update of attachment 40225)
Overall, this is a nice clean-up!  Comments below.

> +    my $mkdirParentsSwitch = (($^O eq "MSWin32") ? "" : "-p");

A couple things here:

- Instead of making a custom $mkdirParentsSwitch variable, I'd rather see you
add an @mkdirArgs variable, and only add the "-p" switch to it if necessary.

my @mkdirArgs;
push @mkdirArgs, "-p" if !isWindows();

- The ($^O eq "MSWin32") test should really be isWindows() instead.  (If you
don't want to test for Cygwin, then fix isWindows() to only test for Windows,
and update run-webkit-test to use "isCygwin() || isWindows()" in the place
where it uses isWindows() now.)

The rest of the changes look good!

r- to address the above issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.