[Webkit-unassigned] [Bug 29808] [Qt] assertions to be visible on Symbian

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29808


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40236|review?                     |review-
               Flag|                            |




--- Comment #1 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2009-09-28 16:35:00 PDT ---
(From update of attachment 40236)
> diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
> index f6a644a..894ff9a 100644
> --- a/JavaScriptCore/ChangeLog
> +++ b/JavaScriptCore/ChangeLog
> @@ -1,3 +1,15 @@
> +2009-09-28  Janne Koskinen  <janne.p.koskinen at digia.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Qt] Assert messages prints visible in Symbian
> +
> +        Asserts use vprintf to print the messages to stderr.
> +        In Symbian Open C it is not possible to see stderr so
> +        I routed the messages to stdout instead.
> +
> +        * wtf/Assertions.cpp:
> +

Please include a reference to the bug URL in the ChangeLog entry.

> +#ifdef PLATFORM(SYMBIAN)

This should be:

#if PLATFORM(SYMBIAN)

r- to address the above issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.