[Webkit-unassigned] [Bug 28884] [Qt] Add CreateRequestExtension to QWebPage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28884





--- Comment #10 from robert <robert at roberthogan.net>  2009-09-28 12:32:57 PDT ---
(In reply to comment #9)
> I admit I still don't understand why such a complex API is necessary, in
> particular that the implementation of the extension _has_ to copy in the
> incoming request into the output argument, otherwise you get random crashes.
> That IMHO is bad and too complex API.
> 

I agree with you here, though I think the complexity is largely a feature of
the extension() API design.

> Why is it necessary to allow the developer to provide a complete replacement
> for the network request?
> 
> Why wouldn't a simple single notification signal in QWebPage (with a frame and
> the request as argument) be sufficient for your use-case?

It would certainly be sufficient for my use-case and I would happily proceed on
that basis.

If I understand the discussion that has taken place on this, the extension()
API offers the following benefits over a simple signal:

1. It supports the design decision of introducing the extension() API, i.e.
it's the new Qt-ish way of doing things.
2. It exposes the QNetworkRequest attributes() to clients in a way that  allows
them to make better use of them than is currently available.

That's my (possibly) incomplete understanding of it. I think Ben or others may
be able to add more to the case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.