[Webkit-unassigned] [Bug 22261] Clicking button input does not give it focus

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22261


Viatcheslav Ostapenko <ostapenko.viatcheslav at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ostapenko.viatcheslav at nokia
                   |                            |.com




--- Comment #7 from Viatcheslav Ostapenko <ostapenko.viatcheslav at nokia.com>  2009-09-28 10:51:23 PDT ---
(In reply to comment #6)
> (From update of attachment 40241 [details])
> This is wrong for Mac OS X at least,

Have tried it on Mac. 
Good test page
http://testsuite.nokia-boston.com/content/xhtml_forms/text_input/form_input.xhtml

1. Radio buttons and check boxes are not focusable by mouse
2. Radio buttons and check boxes also not focusable through tabbed browsing.
Weird! It's different from all other browsers.

So, radio buttons and check box lists are some special exceptions?

> so please don't check this in without further discussion. 

Yes, that's what I want.

> This might need to be discussed on the webkit-dev mailing
> list rather than just in this bug.

Could you start this discussion? I hope this way it will attract more
attention.

> Also, this patch has no change log 

I never hoped that this will go as it is. It just to start the discussion.

> or test case, 

Isn't it so, that tests attached to the bug are also tests for the fix?
In any case, here is good test page:
http://testsuite.nokia-boston.com/content/xhtml_forms/text_input/form_input.xhtml

> so it needs to be review- in any case.

That's Ok.
1st I need to figure out what is correct behavior in this case.
My impression now, that #if PLATFORM(GTK) should be changed to 
#if PLATFORM(MAC)
    return false;
#else
    return HTMLElement::isMouseFocusable();
#endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.