[Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28303


Jakub Wieczorek <faw217 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40244|                            |review?
               Flag|                            |
  Attachment #39427|0                           |1
        is obsolete|                            |




--- Comment #50 from Jakub Wieczorek <faw217 at gmail.com>  2009-09-28 10:49:28 PDT ---
Created an attachment (id=40244)
 --> (https://bugs.webkit.org/attachment.cgi?id=40244)
[Qt] Implement XSLT support with QtXmlPatterns.

(In reply to comment #47)
> (From update of attachment 39427 [details])
> 
> From what I can see this is very good, except for a tiny TransformSource
> buglet:
> 
> > -void Document::setTransformSource(void* doc)
> > +void Document::setTransformSource(TransformSource* source)
> >  {
> > -    if (doc == m_transformSource)
> > -        return;
> > -
> > -    xmlFreeDoc((xmlDocPtr)m_transformSource);
> > -    m_transformSource = doc;
> > +    m_transformSource = source;
> >  }
> 
> Technically this function was protected against self-assignment and isn't
> anymore. One could
> argue it's a bug in OwnPtr perhaps?
> 
> > +    void setTransformSource(TransformSource*);
> > +    TransformSource* transformSource() const { return m_transformSource.get(); }
> >  #endif
> 
> I believe the setter should take a PassOwnPtr<TransformSource>, to make it safe
> and clear that ownership is passed here.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.